Include on-chain payments in list payments API#219
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
benthecarman
force-pushed
the
fix-onchain-payments
branch
from
ad05e31 to
4889d15
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Hmm, I'm confused why we need this, isn't the plan to enable pagination on LDK Node's payment store and to drop the separate paginated store in Server entirely?
Yeah this is a temporary fix
|
ListPayments only read from ldk-server's paginated payment store, which is populated from Lightning payment events. On-chain payments are stored by LDK Node directly, so they never appeared in paginated list responses. Backfill on-chain payments from LDK Node before reading the existing paginated store. This keeps list payments complete until LDK Node owns paginated listing for both Lightning and on-chain payments. Add an e2e test covering an on-chain send appearing in list payments.
benthecarman
force-pushed
the
fix-onchain-payments
branch
from
4889d15 to
14ea435
Compare
|
just gonna leave the bug until fixed it in ldk-node (will be fixed before we release) |
4 participants
ListPayments only read from ldk-server's paginated payment store, which is populated from Lightning payment events. On-chain payments are stored by LDK Node directly, so they never appeared in paginated list responses.
Backfill on-chain payments from LDK Node before reading the existing paginated store. This keeps list payments complete until LDK Node owns paginated listing for both Lightning and on-chain payments. Eventually we can remove this when we use the paginated KV store all throughout ldk-node.
Add an e2e test covering an on-chain send appearing in list payments.